Conversation
772622d to
46ded78
Compare
This was referenced Jan 3, 2019
jcheng5
approved these changes
Jan 4, 2019
This also changes the function names in tinycthread so that they don't conflict with (and inadverantly link to) functions with the same name from C11-style threads.h.
48cc5fb to
612536f
Compare
QuLogic
reviewed
Feb 12, 2019
| * system's functions that have the same name, instead of the local functions. | ||
| */ | ||
|
|
||
| #define thrd_t THREADS_H_ERROR |
There was a problem hiding this comment.
This name (thrd_t) still exists even though it's listed here as bad. Pretty sure that means that THREADS_H_ERROR becomes the name of the type, which does mean the wrong type name is avoided, but I'm not sure that's what was intended.
|
On a related note, names ending in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77. This PR makes it so later stops trying to use C11-style threads.
It changes the function names in tinycthread so that they don't conflict with (and inadverantly link to) functions with the same name from C11-style threads.
Installation can be tested by building the Fedora 29-Anaconda Docker image as described in #77, then running the following:
For some reason,
R CMD checkdoesn't work, but I think it's because there's some missing system dependencies.