Present tense / past tense mixing

[damianooldoni]

Hi 👋

I am really enjoying using lifecycle 👏
I have just found an "inconsistency" in the warnings returned:

• past tense for deprecated function: "[..] was deprecated in [..]"
• present tense for deprecated argument: "[..] is deprecated as of [..]"

Shouldn't be always the same tense?

See reprex, where lifecycle 1.0.4 and R 4.4.1 has been used (Windows OS). Thanks in advance.

library(lifecycle)
a <- function(x) {
  lifecycle::deprecate_warn(when = "1.0.0",
                            what = "a()",
                            with = "b()",
                            always = TRUE
  )
  lifecycle::deprecate_warn(
    when = "1.0.0",
    what = "a(x)",
    with = "b(y)",
    always = TRUE
  )
}

# Run the function - returns the warnings
a(x = 1)
#> Warning: `a()` was deprecated in <NA> 1.0.0.
#> ℹ Please use `b()` instead.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.
#> Warning: The `x` argument of `a()` is deprecated as of <NA> 1.0.0.
#> ℹ Please use the `y` argument of `b()` instead.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.

^{Created on 2024-07-25 with reprex v2.1.0}