Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated_stop() should say defunct instead of deprecated #28

Closed
hadley opened this issue Dec 13, 2019 · 3 comments
Closed

deprecated_stop() should say defunct instead of deprecated #28

hadley opened this issue Dec 13, 2019 · 3 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Dec 13, 2019

> lifecycle::deprecate_stop("1.0.0", "foo()", "foo(bar = )")
Error: `foo()` is deprecated as of <NA> 1.0.0.
Please use the `bar` argument instead.
@lionel-

This comment has been minimized.

Copy link
Member

@lionel- lionel- commented Feb 7, 2020

This isn't a straightforward change because it requires providing a full deprecation cycle as package versions. Or at least change the meaning of the version in deprecate_stop() so that it represents the version at which the function stopped working instead of the version at which it was deprecated.

The UI was made to minimise intervention when bumping the lifecycle, so that all _warn can be bumped to _stop by bulk search&replace for instance.

@hadley

This comment has been minimized.

Copy link
Member Author

@hadley hadley commented Feb 7, 2020

Maybe “foo() was deprecated in PKG VERSION and is now defunct”?

@lionel-

This comment has been minimized.

Copy link
Member

@lionel- lionel- commented Feb 7, 2020

why didn't I think of that :)

@lionel- lionel- closed this in f596950 Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.