Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support deprecating assignment functions #95

Closed
hadley opened this issue Jan 29, 2021 · 0 comments · Fixed by #97
Closed

Better support deprecating assignment functions #95

hadley opened this issue Jan 29, 2021 · 0 comments · Fixed by #97

Comments

@hadley
Copy link
Member

hadley commented Jan 29, 2021

Why did this used to work?

term::`parameters<-`
#> function (x, value) 
#> {
#>     deprecate_soft("0.1.0", what = "parameters<-", with = "pars<-")
#>     pars(x) <- value
#>     x
#> }
#> <bytecode: 0x7fe02759b3e0>
#> <environment: namespace:term>

Created on 2021-01-29 by the reprex package (v0.3.0.9001)

Also think about

lifecycle::deprecate_warn("0.1.0", what = "`parameters<-`()", with = "`pars<-`()")
#> Warning: ``parameters<-`()` was deprecated in <NA> 0.1.0.
#> Please use ``pars<-`()` instead.

Created on 2021-01-29 by the reprex package (v0.3.0.9001)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant