Only generate the trace_back()
as needed
#177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #172
I was investigating tidyverse/dplyr#6897 with dev lifecycle installed and discovered a lot of the remaining time spent in repeated calls to
deprecate_soft()
anddeprecate_warn()
withalways = FALSE
is in generating thetrace_back()
, which we throw away every single time except for the very first one.I've moved the
trace_back()
call after our early exit, which cuts the time fordeprecate_soft()
in half againCurrent dev main
This PR