Further extensions to paste_linter

[MichaelChirico]

Branched off from #998 -- creating this issue to cover the remaining paste-related lints mentioned there that aren't making the 3.0.0 cut

• Upstreaming linters from Google's internal linting suite #884 PasteFilePathLinter: paste(sep = "/") ➡️ file.path()
• Upstreaming linters from Google's internal linting suite #884 PasteStrrepLinter: paste(rep(), collapse="") ➡️ strrep() extend paste_linter() for strrep() equivalents #1652
• paste0(x, collapse = ) ➡️ paste(x, collapse = )

[olivroy]

I just tripped on

paste0(x, collapse = )

Would love to see this implemented!

[MichaelChirico]

Could you elaborate what you mean by "tripped on"? The behavior of paste(x, collapse=) should be identical to that of paste0(x, collapse=), the advantage here is only for consistency/possibly readability, not anything to do with correctness.

[olivroy]

Oh, actually, I tripped on paste0(sep =). sep is ignored by paste0() which yielded bad results. Sorry for the confusion!

Edit: and there is already a linter for this. Please disregard :)

[MichaelChirico]

Your use case is already covered by paste_linter():

lintr::lint(text='paste0(a, sep="b")', linters=lintr::paste_linter())
# <text>:1:1: warning: [paste_linter] sep= is not a formal argument to paste0(); did you mean to use paste(), or collapse=?
# paste0(a, sep="b")
# ^~~~~~~~~~~~~~~~~~