Skip to content

Export xml_nodes_to_lint()? #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AshesITR opened this issue May 3, 2022 · 2 comments · Fixed by #1140
Closed

Export xml_nodes_to_lint()? #1124

AshesITR opened this issue May 3, 2022 · 2 comments · Fixed by #1140
Assignees
Milestone

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented May 3, 2022

Used in most linters by now, because it's a very useful helper for XPath-based linting.
Since we already export with_id and ids_with_token as helpers for the parse data based approach, I think we could also export xml_nodes_to_lint().

Also thinking about the function name: Shouldn't this be either vectorized (on nodesets or lists of nodes) or singular (xml_node_to_lint())?

cc @MichaelChirico

@MichaelChirico
Copy link
Collaborator

SGTM-- had the same thought about vectorizing.

(PS I just moved so it will take me a bit to get things in order and get back to he review/PR queue)

@MichaelChirico MichaelChirico self-assigned this May 16, 2022
@MichaelChirico
Copy link
Collaborator

Assigning this to me -- I have a branch in progress already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants