Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extraction_operator_linter() shouldn't lint code[NULL] #1273

Closed
AshesITR opened this issue May 26, 2022 · 0 comments · Fixed by #1286
Closed

extraction_operator_linter() shouldn't lint code[NULL] #1273

AshesITR opened this issue May 26, 2022 · 0 comments · Fixed by #1286
Assignees
@AshesITR
Labels
false-positive code that shouldn't lint, but does

Comments

@AshesITR
Copy link
Collaborator

spin-off from #1261:

Why do we lint NULL_CONST at all?

letters[NULL]
#> character(0)
letters[[NULL]]
#> Error in letters[[NULL]]: attempt to select less than one element in get1index
@AshesITR AshesITR added the false-positive code that shouldn't lint, but does label May 26, 2022
@AshesITR AshesITR self-assigned this May 26, 2022
AshesITR added a commit that referenced this issue May 26, 2022
@AshesITR
don't lint a[NULL] in extraction_operator_linter()
33dc984 
fixes #1273

needs a news bullet in #834 once merged
AshesITR added a commit that referenced this issue May 26, 2022
@AshesITR
don't lint a[NULL] in extraction_operator_linter()
fa25e2f 
fixes #1273

needs a news bullet in #834 once merged
@AshesITR AshesITR mentioned this issue May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshesITR AshesITR

Labels
false-positive code that shouldn't lint, but does
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't lint a[NULL] in extraction_operator_linter() r-lib/lintr
1 participant
@AshesITR