unreachable_code_linter hits #nolint messages

[MichaelChirico]

function() {
  do_something
  # nolint start: one_linter.
  edge_case_stuff()
  # nolint stop: one_linter.
}

will throw the lint on # nolint stop. this seems less than ideal but I'm not sure if it can be easily fixed.

[AshesITR]

Maybe never lint COMMENT nodes?

[MichaelChirico]

Actually comments were one of the things I definitely wanted to lint. Often see things like

function() {
  do_something()
  # print(x)
}

i.e., vestigial comments that should probably be removed (or at least moved away from the very end of the function)

[AshesITR]

Shouldn't that be a separate lint message at least? Trailing comments aren't exactly unreachable code.

Also, just to clarify, these lints are excluded by exclude(), right?

[MichaelChirico]

Oh, good point. Edited the issue -- they're not excluded because they're specific to a different linter.