Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate find_line and find_column helpers in get_source_expressions? #1373

Closed
MichaelChirico opened this issue Jun 8, 2022 · 1 comment · Fixed by #1374
Closed

Deprecate find_line and find_column helpers in get_source_expressions? #1373

MichaelChirico opened this issue Jun 8, 2022 · 1 comment · Fixed by #1374
Labels
breaking change ☠️ API change likely to affect existing code
Milestone
3.0.0

Comments

@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Jun 8, 2022 •
edited
Loading

These are totally unused now in our sources, and completely untested. Should we move to start deprecating these?

If so, now is the time to do it of course.
@MichaelChirico MichaelChirico added the breaking change ☠️ API change likely to affect existing code label Jun 8, 2022
@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Jun 8, 2022
@MichaelChirico

This comment was marked as outdated.

Sign in to view
@MichaelChirico MichaelChirico mentioned this issue Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ☠️ API change likely to affect existing code
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Deprecate find col r-lib/lintr
1 participant
@MichaelChirico