Skip to content

extract_r_source() fix is buggy for knitr files without R chunks #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AshesITR opened this issue Jun 19, 2022 · 0 comments · Fixed by #1416
Closed

extract_r_source() fix is buggy for knitr files without R chunks #1415

AshesITR opened this issue Jun 19, 2022 · 0 comments · Fixed by #1416
Labels
bug an unexpected problem or unintended behavior

Comments

@AshesITR
Copy link
Collaborator

Seen in devtools/tests/testthat/testVignetteExtras/vignettes/new.Rnw

Causes the fixed terminal_newline_linter() to return a line_number of 0, which errors.
@AshesITR AshesITR mentioned this issue Jun 19, 2022
Merged
@AshesITR AshesITR added the bug an unexpected problem or unintended behavior label Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return non-empty file_lines even if no R source is present r-lib/lintr
1 participant
@AshesITR