Skip to content

Make sure Quarto files (.qmd) are supported #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IndrajeetPatil opened this issue Jul 29, 2022 · 3 comments · Fixed by #1487
Closed

Make sure Quarto files (.qmd) are supported #1486

IndrajeetPatil opened this issue Jul 29, 2022 · 3 comments · Fixed by #1487
Assignees
Labels
feature a feature request or enhancement

Comments

@IndrajeetPatil
Copy link
Collaborator

Given their similarity to .Rmd files, I think they are supported out of the box.

We just need to update the docs and tests for this.

@IndrajeetPatil IndrajeetPatil added the feature a feature request or enhancement label Jul 29, 2022
@IndrajeetPatil IndrajeetPatil self-assigned this Jul 29, 2022
@IndrajeetPatil IndrajeetPatil added this to the 3.0.1 milestone Jul 30, 2022
@IndrajeetPatil
Copy link
Collaborator Author

The one thing I am not sure about is what to do about unexecuted code blocks like these:

```{{r}}
1+1
```

Should they be linted? Currently, out of the box, we don't. Should that be changed?

Note that, since these are verbatim blocks, even the directive to not lint will show up, which is not desirable:

```{{r}}
1+1 # nolint
```

I personally think they shouldn't be linted since the intent behind these blocks seems to be to show the code as it is, but if we style/lint them, then we are undoing that intent. For example, these blocks can be used to show what code with lints looks like. That said, I am open to hear what other people think.

cc @mine-cetinkaya-rundel

@MichaelChirico
Copy link
Collaborator

essentially the same issue as #773

@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico Good to know.

Should we keep #1487 pending until this is resolved, or come back to dealing with these blocks in a later PR?

IndrajeetPatil added a commit that referenced this issue Sep 29, 2022
* Updates docs and adds tests for Quarto files

Closes #1486

* Update get_source_expressions.Rd

* Update test-trailing_blank_lines_linter.R

* Update test-trailing_blank_lines_linter.R

* Update test-trailing_blank_lines_linter.R

* comment out the offending test example

* Update NEWS and remove lint

* Update test.qmd

* get rid of lints and style

Co-authored-by: Michael Chirico <chiricom@google.com>
@MichaelChirico MichaelChirico modified the milestones: 3.0.3, 3.1.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants