Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN failures, new release requested by 2022-08-30 #1504

Closed
jimhester opened this issue Aug 24, 2022 · 5 comments
Closed

CRAN failures, new release requested by 2022-08-30 #1504

jimhester opened this issue Aug 24, 2022 · 5 comments

Comments

@jimhester
Copy link
Member

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_lintr.html>.

Apparently your package fails its checks in a strict Latin-1* locale,
e.g. under Linux using LANG=en_US.iso88591 (see the debian-clang
results).

Please correct before 2022-08-30 to safely retain your package on CRAN.
@MichaelChirico
Copy link
Collaborator

hey @jimhester have you taken a look at this? I can try and have a go at it this weekend if not... cc @AshesITR

anyone able to reproduce the error current main?

IndrajeetPatil added a commit that referenced this issue Aug 29, 2022
These were slated for the next release after `3.0.0`.

So probably will be part of the release to fix #1504?
jimhester added a commit that referenced this issue Aug 29, 2022
@jimhester
Copy link
Member Author

c061090 should fix the failing tests (by skipping them in non-UTF-8 locales) c061090

I also added a run in the CI for this case to avoid future regressions.

@IndrajeetPatil
Copy link
Collaborator

Although we are past deadline, the package hasn't been archived yet. I am guessing that as long as the submission is under review, they won't do that?

At any rate, the CRAN team seems to be waiting for a response about something?

Screenshot 2022-09-04 at 15 10 51

Source: https://nx10.github.io/cransubs/

@IndrajeetPatil
Copy link
Collaborator

The update is on CRAN now. Thanks, @jimhester!

Screenshot 2022-09-13 at 16 05 41

@MichaelChirico
Copy link
Collaborator

thanks for handling this Jim!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants