Skip to content

consecutive_stopifnot_linter should include assert_that (and hence be renamed) #1604

@MichaelChirico

Description

@MichaelChirico

Similar reasoning for consecutive_stopifnot_linter() applies for using assert_that(); assert_that(); assert_that(); unless a message is specified, it's better to use the ... and condense to one assert_that() call.

This will entail a deprecation cycle for consecutive_stopifnot_linter(), so let's align on a name before continuing.

I think consecutive_assertion_linter() fits well, but differs from conjunct_test_linter() (which also covers assert_that() and stopifnot()).

consecutive_test_linter() sounds more like it would apply to testthat functions, so I'm not sold on it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking change ☠️API change likely to affect existing codefeaturea feature request or enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions