Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expectation_lint() misbehaves when lint number larger than expected [patch] #180

Closed
fangly opened this issue Oct 24, 2016 · 2 comments
Closed

expectation_lint() misbehaves when lint number larger than expected [patch] #180

fangly opened this issue Oct 24, 2016 · 2 comments

Comments

@fangly
Copy link
Contributor

fangly commented Oct 24, 2016

Hi,
When the number of lints is larger than the expected number, expectation_lint() passes 2 strings instead of 1 to testthat::expect, which caused an error.
This patch fixes the issue: 0001-Fixed-expectation_lint-for-when-lint-number-expected.zip
Best,
Florent
@fangly
Copy link
Contributor Author

fangly commented Oct 24, 2016

Note: This patch is based on a git repo freshly initialized from lintr's master branch on 24 Oct (unfortunately, a firewall blocks the ports needed for a git clone, pull, etc).

@fangly fangly changed the title expectation_lint() misbehaves when lint number larger than expected expectation_lint() misbehaves when lint number larger than expected [patch] Oct 26, 2016
@fangly
Copy link
Contributor Author

fangly commented Mar 13, 2017

Fixed in #214

@fangly fangly closed this as completed Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fangly