Skip to content

sprintf_linter is not pipe-aware #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelChirico opened this issue Apr 2, 2023 · 0 comments · Fixed by #2049
Closed

sprintf_linter is not pipe-aware #1943

MichaelChirico opened this issue Apr 2, 2023 · 0 comments · Fixed by #2049
Labels
false-positive code that shouldn't lint, but does

Comments

@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Apr 2, 2023 •
edited
Loading 

letters |>
  sprintf(fmt = "%s")

will throw a lint "too few arguments". Ditto for using %>%.

We can probably re-use the code from unnecessary_concatentation_linter().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive code that shouldn't lint, but does
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for piping into sprintf() in sprintf_linter() r-lib/lintr
1 participant
@MichaelChirico