Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run lintr during covr run #287

Closed
mb706 opened this issue Dec 9, 2017 · 0 comments
Closed

Don't run lintr during covr run #287

mb706 opened this issue Dec 9, 2017 · 0 comments

Comments

@mb706
Copy link

mb706 commented Dec 9, 2017

Running lintr can take quite some time for large packages, so I think it is a good idea to exclude it from being run during a code coverage check (where it is useless?), e.g. when using covr. When lintr is invoked in testthat using expect_lint_free, the test is skipped if NOT_CRAN is not "true". Therefore, when using package_coverage() to get coverage data locally, lintr is excluded.

Travis seems to set NOT_CRAN to "true", however, so I assume lintr is run twice there and is leading to longer Travis build times.

I suggest also checking for the "R_COVR" environment variable in expect_lint_free, and skipping linting it is set to "true".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants