-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lintr-bot does not seem to respect .lintr
file
#345
Comments
I'm experiencing the same problem. The rules defined in a |
I also experience the same problem. |
@javierluraschi I noted that you are using a testthat linting test. Could you confirm if you get the same problem if you remove the testthat call to linting and add an |
I think this is a problem with the working directory when the tests are run, I think I would recommend not using lintr from within your tests. |
we are currently using `lintr` in `testthat` tests -- this is apparently not intended usage (see https://github.com/jimhester/lintr#continuous-integration) and thus our setup does not respect `.lintr` settings (r-lib/lintr#345) --> keep our current setup and turn of verbose `lintr-bot`
See https://github.com/rstudio/mlflow/blob/master/R/mlflow/.lintr changing to line-width to 120 but comments in PR point to 80:
https://github.com/rstudio/mlflow/pull/43
The text was updated successfully, but these errors were encountered: