Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master build failing several lint tests #363

Closed
mattyb opened this issue Jan 15, 2019 · 2 comments
Closed

master build failing several lint tests #363

mattyb opened this issue Jan 15, 2019 · 2 comments

Comments

@mattyb
Copy link
Contributor

mattyb commented Jan 15, 2019

  1.  Failure: return lint report as checkstyle xml (@test-checkstyle_output.R#28) 
  2.  Failure: tab positions have been corrected (@test-get_source_expressions.R#44) 
  3.  Failure: tab positions have been corrected (@test-get_source_expressions.R#44) 
  4.  Failure: Lint all semicolons (@test-semicolon_terminator_linter.R#19) 
  5.  Failure: Lint all semicolons (@test-semicolon_terminator_linter.R#25) 
  6.  Failure: Lint all semicolons (@test-semicolon_terminator_linter.R#33) 
  7.  Failure: Lint all semicolons (@test-semicolon_terminator_linter.R#39) 
  8.  Failure: Lint all semicolons (@test-semicolon_terminator_linter.R#47) 
  9.  Failure: returns the correct linting (@test-todo_comment_linter.R#9) 
  10. Failure: returns the correct linting (@test-todo_comment_linter.R#12) 

the semicolon issues at least seem to be in cases where there are multiple expressions? Maybe related to 27ea9ca. Certainly the first issue, which is looking for something that matches the lintr version

@russHyde
Copy link
Collaborator

russHyde commented Feb 1, 2019

The checkstyle test seems to be failing because lintr now outputs a checkstyle file that has "1.0.3.9000" in the header, whereas the "checkstyle.xml" in the tests folder has "1.0.2.9000".

russHyde added a commit that referenced this issue Feb 1, 2019
mismatching lintr versions between this file and `checkstyle_output()` threw a testthat error. Ref #363
jimhester pushed a commit that referenced this issue Feb 10, 2019
mismatching lintr versions between this file and `checkstyle_output()` threw a testthat error. Ref #363
@russHyde
Copy link
Collaborator

Ci passes in r-3.6.1 as of #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants