Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lintr::lint_package should lint vignettes by default #447

Closed
AshesITR opened this issue Jan 19, 2020 · 2 comments
Closed

lintr::lint_package should lint vignettes by default #447

AshesITR opened this issue Jan 19, 2020 · 2 comments
Labels
feature a feature request or enhancement

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented Jan 19, 2020 •
edited
Loading

Since linting is possible for vignettes, it should be the default for lintr::lint_package() to also lint package vignettes.

This line just needs "vignettes" as an additional directory and "\\.[Rr](md|)$" as a pattern for that to work:

https://github.com/jimhester/lintr/blob/dbc76246c244e89f04be3031ff6db1dbe26960ac/R/lint.R#L238
@russHyde
Copy link
Collaborator

This seems quite reasonable, @AshesITR would you be interested in implementing this?

@russHyde russHyde added the feature a feature request or enhancement label Mar 30, 2020
@AshesITR
Copy link
Collaborator Author

AshesITR commented Apr 2, 2020 •
edited
Loading

Sure thing 👍
I wonder if "data-raw" should also be included?
That's the suggested location for data creation scripts as per Hadley.

@AshesITR AshesITR mentioned this issue May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AshesITR @russHyde