Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renv and packrat to default-excluded directories #697

Closed
russHyde opened this issue Dec 7, 2020 · 3 comments · Fixed by #721
Closed

Add renv and packrat to default-excluded directories #697

russHyde opened this issue Dec 7, 2020 · 3 comments · Fixed by #721
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors
Milestone

Comments

@russHyde
Copy link
Collaborator

russHyde commented Dec 7, 2020

#492
Suggest modifying the exclusions param in lint_dir and linr_package to drop common directories (renv, packrat)

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 8, 2020

That usecase was the main motivation for me to code up the directory exclusion as well. The risk for unintended exclusion of those two is minimal so making them the default sounds like a good idea.

@russHyde russHyde added feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors labels Dec 9, 2020
@AshesITR
Copy link
Collaborator

AshesITR commented Dec 9, 2020

NB why would one use renv or packrat in a Package?
Maybe better to only add this default for lint_dir. WDYT?

@russHyde
Copy link
Collaborator Author

russHyde commented Dec 9, 2020

Sorry, you are right. I never use either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants