Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move line_length_linter column to one past length #735

Closed
AshesITR opened this issue Feb 3, 2021 · 0 comments · Fixed by #736
Closed

Move line_length_linter column to one past length #735

AshesITR opened this issue Feb 3, 2021 · 0 comments · Fixed by #736
Milestone
3.0.0

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented Feb 3, 2021

Oh sorry, I misunderstood. IIUC the ^~~~ tag is only built from ranges. So column_number should be fine to update. But perhaps best to keep as a follow-up to keep the PR more focused.

Originally posted by @MichaelChirico in #734 (comment)

Makes the source marker more useful for fixing the lint, since it places the cursor at the spot where a line break should occur instead of at the start of the line.
@AshesITR AshesITR added this to the 3.0.0 milestone Feb 3, 2021
AshesITR added a commit that referenced this issue Feb 3, 2021
@AshesITR
Improve source marker placement for line_length_linter
226f880 
fixes #735
@AshesITR AshesITR mentioned this issue Feb 3, 2021
Merged
3 tasks
MichaelChirico added a commit that referenced this issue Feb 10, 2021
@AshesITR @MichaelChirico
Improve source marker placement for line_length_linter (#736)
d17a631 
* Improve source marker placement for line_length_linter

fixes #735

* improve wording

* end -> margin

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Improve source marker placement for line_length_linter r-lib/lintr
1 participant
@AshesITR