-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object_length_linter
should detect generics
#871
Comments
Yes! I've been bitten by this many times and have |
For now, I've even disabled the linter alltogether in the |
Should this be an option? |
I'd be happy to make it optional. What should the default be? The old behaviour? |
I think the new behavior is a happier default -- often it's out of your control if you're defining a method for someone else's class. WDYT about a third option -- enforce the length on two parts (class name and generic name)? not sure it's worth the implementation & maintenance effort but it does make some sense |
We could combine both by specifying two maximum lengths? |
* Refactor `object_length_linter` to properly handle generics Fixes #871 * document() * incorporate feedback * put S3 tests in their own unit Co-authored-by: Michael Chirico <chiricom@google.com>
As the
object_name_linter
already does, class suffixes for S3 generics shouldn't be part of the linted symbol.That is,
object_length_linter(30)
(the default) shouldn't lint this example:The text was updated successfully, but these errors were encountered: