Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_multiple_spaces = TRUE to infix_spaces_linter() to fully replace assignment_linter() #940

Closed
AshesITR opened this issue Mar 14, 2022 · 2 comments · Fixed by #1075
Milestone

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented Mar 14, 2022

Since @f-ritter's original use-case was disallowing these, I think we should also support that rule via an argument (allow_multiple_spaces = TRUE). WDYT?

Originally posted by @AshesITR in #931 (comment)

NB: The implementation will likely be easier using XPath instead of ids_with_token.

@MichaelChirico
Copy link
Collaborator

Copying comment from the thread too:

should be a lot easier if we convert the linter to XPath at the same time (requires something like following-sibling::[@col1 = preceding-sibling::/@Col2] vs. > preceding-sibling::*/@Col2 iinm)

@MichaelChirico
Copy link
Collaborator

NB: be sure to offer attribution for this fix when this is filed. The following was lost in #931

New assignment_spaces() lintr. (#538, @f-ritter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants