-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object_usage_linter doesn't match R CMD check #941
Comments
PS I think this linter should be tagged as |
Is there a legitimate true positive caused by BTW: checkUsage(fun, name = "<anonymous>", report = cat, all = FALSE,
suppressLocal = FALSE, suppressParamAssigns = !all,
suppressParamUnused = !all, suppressFundefMismatch = FALSE,
suppressLocalUnused = FALSE, suppressNoLocalFun = !all,
skipWith = FALSE, suppressUndefined = dfltSuppressUndefined,
suppressPartialMatchArgs = TRUE)
|
As seen here: #931 (comment)
Basically our
tools::checkUsage()
call doesn't match that ofR CMD check
. In this case, it's because the defaultcheckUsage()
doesn't setskipWith=TRUE
, so objects seen insidewith()
calls can trip the linter.My understanding is the main goal of
object_usage_linter
is to help matchR CMD check
, so we should adjust our code to match.But maybe we think of this as a bit more general, and could expose an option instead (e.g.
match_r_check
, I would setTRUE
by default).The text was updated successfully, but these errors were encountered: