Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn if some NULLs are not in default #1049

Merged
merged 3 commits into from
Apr 4, 2022
Merged

warn if some NULLs are not in default #1049

merged 3 commits into from
Apr 4, 2022

Conversation

AshesITR
Copy link
Collaborator

@AshesITR AshesITR commented Apr 4, 2022

No description provided.

@AshesITR AshesITR mentioned this pull request Apr 4, 2022
Closed
MichaelChirico
MichaelChirico approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in case there's nothing to add to the warning to help orient the user what 'default' is

@AshesITR AshesITR merged commit 05d5bd4 into master Apr 4, 2022
@AshesITR AshesITR deleted the feature/with-defaults-safe-null branch April 4, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshesITR @MichaelChirico