refactor function_left_parentheses_linter() to XPath #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1266 also improved location info (I think?) and added tests for that. renamed the file to function_left_parentheses_linter.R for consistency.
| @@ -0,0 +1,32 @@ | |||
| #' Function left parentheses linter | |||
There was a problem hiding this comment.
i guess it didn't pick up the rename... a shame for the got history...
There was a problem hiding this comment.
Could do an interactive rebase to split the rename from the modifications?
MichaelChirico
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1266
also improved location info and added tests for that.
renamed the file to function_left_parentheses_linter.R for consistency.
lintr::lint(text = "blah (1)", linters = function_left_parentheses_linter())Will add a NEWS to #834 when this is merged.