-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor object_usage_linter()
to use xml_nodes_to_lint()
#1285
Conversation
Need a news bullet for improved location info in #834 once merged. Not happy with the performance atm. Looking into it. |
Improvements halves the time, but still at 14.5s vs. 5.7s for main on tools/QC.R. |
Okay, turns out This probably speeds up all linters using the default location info when they generate many lints. |
fixes #1284
get_content()
to acceptxml_node
as info input and use line info as wellparse_check_usage()
get_assignment_symbols()
by usingget_r_string()
instead of hand-rolled unescaping