Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_name_linter: add regexes= argument for custom style regexes #1421

Merged
merged 23 commits into from
Oct 15, 2022

Conversation

AshesITR
Copy link
Collaborator

Fixes #822

AshesITR added 2 commits July 11, 2022 10:09
…or auto-named regexes.

fix test failure pertaining to is_linter not being a linter factory.
@AshesITR AshesITR requested a review from MichaelChirico July 11, 2022 08:22
@MichaelChirico MichaelChirico added this to the 3.0.1 milestone Jul 25, 2022
@MichaelChirico

This comment was marked as resolved.

@IndrajeetPatil

This comment was marked as resolved.

@MichaelChirico

This comment was marked as resolved.

@IndrajeetPatil
Copy link
Collaborator

@AshesITR Resolved a merge conflict to prevent this one from drifting too much away from the main.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Merging #1421 (1abdfdb) into main (6d8f446) will decrease coverage by 0.01%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
- Coverage   98.77%   98.75%   -0.02%     
==========================================
  Files         104      105       +1     
  Lines        4497     4510      +13     
==========================================
+ Hits         4442     4454      +12     
- Misses         55       56       +1     
Impacted Files Coverage Δ
R/object_name_linter.R 98.11% <95.23%> (ø)
R/object_length_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelChirico
Copy link
Collaborator

Hey @AshesITR I think it's time to start getting a release going in the next few weeks. Please drop this from the milestone if you're short on time (no pressure, just want to clarify what's still pending)

@MichaelChirico MichaelChirico modified the milestones: 3.0.2, 3.1.0 Oct 13, 2022
@AshesITR
Copy link
Collaborator Author

Sorry for the delayed reaction.
I'll see if I can invest some time today.
No worries if that's too late to the party for 3.0.2 😊

@AshesITR
Copy link
Collaborator Author

@MichaelChirico PTAL what you think. Still needs a NEWS entry, but the rest is complete.
I also took the freedom to split object_name_linters.R into separate files for the two linters to improve on the consistency R/*.R -> tests/testhat/test-*.R

@AshesITR AshesITR modified the milestones: 3.1.0, 3.0.2 Oct 15, 2022
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@MichaelChirico MichaelChirico merged commit 7a953f5 into main Oct 15, 2022
@MichaelChirico MichaelChirico deleted the feature/822-object_name-custom-style branch October 15, 2022 14:42
@AshesITR
Copy link
Collaborator Author

This still needs a NEWS. Do you want to write a bullet?

@MichaelChirico
Copy link
Collaborator

whoops, got too excited :)

feel free to write one if you're still at it, I am logging off for the day

@MichaelChirico MichaelChirico modified the milestones: 3.0.3, 3.1.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding shiny module names to custom whitelist
4 participants