-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object_name_linter: add regexes=
argument for custom style regexes
#1421
Conversation
…or auto-named regexes. fix test failure pertaining to is_linter not being a linter factory.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@AshesITR Resolved a merge conflict to prevent this one from drifting too much away from the main. |
Codecov Report
@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
- Coverage 98.77% 98.75% -0.02%
==========================================
Files 104 105 +1
Lines 4497 4510 +13
==========================================
+ Hits 4442 4454 +12
- Misses 55 56 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hey @AshesITR I think it's time to start getting a release going in the next few weeks. Please drop this from the milestone if you're short on time (no pressure, just want to clarify what's still pending) |
Sorry for the delayed reaction. |
# Conflicts: # R/object_name_linters.R
…_linter.R for consistency
@MichaelChirico PTAL what you think. Still needs a NEWS entry, but the rest is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
This still needs a NEWS. Do you want to write a bullet? |
whoops, got too excited :) feel free to write one if you're still at it, I am logging off for the day |
Fixes #822