Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include rlang functions in literal coercion #1437

Merged
merged 19 commits into from
Jul 2, 2022
Merged

include rlang functions in literal coercion #1437

merged 19 commits into from
Jul 2, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Jun 28, 2022 •
edited
Loading

Closes #1382

@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review June 28, 2022 07:25
@IndrajeetPatil
Copy link
Collaborator Author

Not sure about the warning message yet.

@MichaelChirico MichaelChirico mentioned this pull request Jun 28, 2022
Closed
MichaelChirico
MichaelChirico reviewed Jul 1, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico mentioned this pull request Jul 1, 2022
Closed
@MichaelChirico
Copy link
Collaborator

just about ready to go -- looking good!

@MichaelChirico MichaelChirico reopened this Jul 2, 2022
@IndrajeetPatil IndrajeetPatil merged commit 1a170f5 into r-lib:main Jul 2, 2022
@IndrajeetPatil IndrajeetPatil deleted the 1382_rlang_literal branch July 2, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include rlang::int(1) and similar in literal_coercion_linter
2 participants
@IndrajeetPatil @MichaelChirico