Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seq linter: 1:length(...) and similar expressions #155

Merged
merged 5 commits into from
May 24, 2016
Merged

Seq linter: 1:length(...) and similar expressions #155

merged 5 commits into from
May 24, 2016

Conversation

gaborcsardi
Copy link
Member

It finds 1:length(...), 1:nrow(...), 1:ncol(...), 1:NROW(...) and 1:NCOL(...) expressions, everywhere.

Maybe we should restrict it into for loop conditions, I am not sure.

It depends on the XML data, thus the #154 PR.

I'll add a bullet to the NEWS.

@jimhester jimhester merged commit c7ef33b into r-lib:master May 24, 2016
@jimhester
Copy link
Member

Thanks Gabor, this is awesome, now I need to go back and rewrite some of the old linters using XPath. I imagine it will make the code cleaner and probably faster as well...

@gaborcsardi
Copy link
Member Author

Thanks for merging! I'll add more linters that use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants