Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing spaces around "and" in glue_collapse() #1946

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

Bisaloo
Copy link
Collaborator

@Bisaloo Bisaloo commented Apr 3, 2023

Example error message at the moment:

Error in linters_with_tags(tags = NULL) :
Linters ‘implicit_assignment_linter’, ‘matrix_apply_linter’, ‘quotes_linter’and‘unnecessary_concatenation_linter’ advertised by available_linters() but not exported by package lintr.

@MichaelChirico
Copy link
Collaborator

code LGTM!

needs a news item (since this is present on CRAN) and a regression test would be good too.

Thanks!

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Apr 3, 2023

Lints are unrelated to my changes. Should I fix them here or open another PR, wait for it to be merged and rebase?

mockery::stub(
linters_with_tags,
"available_linters",
data.frame(linter = c("fake_linter", "super_fake_linter"), package = "lintr", tags = "test")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lint is new

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #1946 (4534eb0) into main (2997038) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 4534eb0 differs from pull request most recent head e73fa26. Consider uploading reports for the commit e73fa26 to get more accurate results

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
+ Coverage   98.86%   98.94%   +0.08%     
==========================================
  Files         113      113              
  Lines        4939     4939              
==========================================
+ Hits         4883     4887       +4     
+ Misses         56       52       -4     
Impacted Files Coverage Δ
R/with.R 98.52% <100.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil
Copy link
Collaborator

You can ignore them in this PR.

#1879 handles this issue.

Bisaloo and others added 3 commits April 3, 2023 17:04
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
@MichaelChirico MichaelChirico merged commit ddc1b71 into r-lib:main Apr 3, 2023
@Bisaloo Bisaloo deleted the spaces-glue_collapse branch April 3, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants