-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing spaces around "and" in glue_collapse() #1946
Conversation
code LGTM! needs a news item (since this is present on CRAN) and a regression test would be good too. Thanks! |
Lints are unrelated to my changes. Should I fix them here or open another PR, wait for it to be merged and rebase? |
tests/testthat/test-with.R
Outdated
mockery::stub( | ||
linters_with_tags, | ||
"available_linters", | ||
data.frame(linter = c("fake_linter", "super_fake_linter"), package = "lintr", tags = "test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lint is new
Codecov Report
@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
+ Coverage 98.86% 98.94% +0.08%
==========================================
Files 113 113
Lines 4939 4939
==========================================
+ Hits 4883 4887 +4
+ Misses 56 52 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
You can ignore them in this PR. #1879 handles this issue. |
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Example error message at the moment: