lintr:::print.lint issue #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed an issue that caused a Error in rep.int(character, length) : invalid 'times' value that caused an issue when printing results from the single_quotes_lintr It was assumed in highlight_string that the range was such that range[1] < range[2] which is not necessarily the case when the string is split over a new line. Added a test case for this too.
|
Thanks! Can you please add a bullet to NEWS? It should briefly describe the change and end with |
|
Done, no issue number attached as don't think it was raised prior, just came across it earlier today |
jimhester
approved these changes
Feb 17, 2020
|
Thanks! |
|
No worries, it's a pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed an issue that caused a
Error in rep.int(character, length) : invalid 'times' value
that caused an issue when printing results from the single_quotes_lintr
It was assumed in highlight_string that the range was such that
range[1] < range[2] which is not necessarily the case when
the string is split over a new line. Added a test case for this
too.