handle empty arguments in switch statements #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that there was a conflict between the comma spacing linter and the infix operator linter when using switch statements that have fall-through arguments like
switch(foo, x = , y = bar, z = baz)
. If there is a space in thex
argument between the=
and the,
, then the comma spacing linter complains; if there is no space there the infix operator linter complains.I consulted the
vctrs
documentation here (because that's what originally made me useswitch
) and saw it was written with the space, so I modified the comma linter to allow these types of lines.I'm happy to take feedback on my approach; I'm not too confident using base R.