Allow .onLoad and other special functions regardless of name style #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove relevant # nolint in lintrs own .onLoad. fixes #500
AshesITR
commented
Nov 28, 2020
| @@ -240,6 +240,7 @@ is_base_function <- function(x) { | |||
| x %in% base_funs | |||
| } | |||
|
|
|||
| # see ?".onLoad" and ?"Startup" | |||
There was a problem hiding this comment.
Thanks, very good idea to note where they come from :-)
MichaelChirico
previously approved these changes
Nov 28, 2020
|
@MichaelChirico can you re-approve (merging master wasn't clean)? Thanks! |
MichaelChirico
approved these changes
Nov 29, 2020
| ".Last" | ||
| ) | ||
|
|
||
| is_special_function <- function(x) { |
There was a problem hiding this comment.
hmm I guess we need a test for this 😅 I'm seeing this on current master when trying to do #597:
R/zzz.R:185:1: style: Variable and function name style should be snake_case.
.onLoad <- function(libname, pkgname) {
^~~~~~~
There was a problem hiding this comment.
The issue is that strip_names removes the leading .. So actually we need to search for onLoad etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove relevant # nolint in lintrs own .onLoad.
fixes #500