-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint_package returns early when no package is found #776
Conversation
Shouldn't this be an error condition? |
An error seems harsh, though maybe the return should just be NULL? Ran into this trying to create a test for #702 -- easiest test is to make sure a |
I would return NULL for If not, a warning ("No package was found at '/path'."?) with |
I'm still happy with warn + return Also it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please add a NEWS bullet.
On HEAD this gives me a funny error:
Should we issue a warning here?