Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence testthat suite #967

Merged
merged 13 commits into from
Mar 21, 2022
Merged

Silence testthat suite #967

merged 13 commits into from
Mar 21, 2022

Conversation

AshesITR
Copy link
Collaborator

@AshesITR AshesITR commented Mar 21, 2022 •
edited
Loading

Fixes #965
Fixes #966

  • test-backport_linter.R:9 Warning bubbles backport_linter() warns multiple times #966
  • test-cache.R produces output
  • test-cache.R:91 Two warnings bubble
  • test-ci.R:39 Deprecation warning for with_mock()
  • test-ci.R:52 Deprecation warning for with_mock()
  • test-dir_linters.R produces output
  • test-expect_lint.R produces output
  • test-expect_lint.R:59 calls RStudio API
  • test-knitr_formats.R produces output
  • test-lint_package.R produces output
  • test-methods.R:117 Deprecation warning for with_mock()
  • test-methods.R:129 calls RStudio API
  • test-object_usage_linter.R produces output
  • test-rstudio_markers.R:97 Deprecation warning for with_mock()
  • corrected minor typo in rstudio_source_markers() error message.

AshesITR
AshesITR commented Mar 21, 2022
View reviewed changes
R/lint.R Show resolved Hide resolved
AshesITR
AshesITR commented Mar 21, 2022
View reviewed changes
tests/testthat/test-cache.R Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Mar 21, 2022
View reviewed changes
R/backport_linter.R Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico mentioned this pull request Mar 21, 2022
Closed
@MichaelChirico
Copy link
Collaborator

Thanks for taking care of this!

This was referenced Mar 21, 2022
Closed
Closed
@MichaelChirico MichaelChirico merged commit 74f1e9d into master Mar 21, 2022
@MichaelChirico MichaelChirico deleted the fix/testthat-3e-output branch March 21, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

backport_linter() warns multiple times Messy testthat output due to 3e
2 participants
@AshesITR @MichaelChirico