From 4fbef77c2dfbb2d5e197057a042a12264b158c7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Tue, 15 Dec 2020 05:41:50 +0100 Subject: [PATCH 1/3] Also show objects that start with a dot for environments --- R/ref.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/ref.R b/R/ref.R index 9d7b34f..be743ac 100644 --- a/R/ref.R +++ b/R/ref.R @@ -60,7 +60,7 @@ ref_tree <- function(x, character = FALSE, seen = child_env(emptyenv()), layout if (is.list(x)) { subtrees <- lapply(x, ref_tree, layout = layout, seen = seen, character = character) } else if (is.environment(x)) { - subtrees <- lapply(as.list(x), ref_tree, layout = layout, seen = seen, character = character) + subtrees <- lapply(as.list(x, all.names = TRUE), ref_tree, layout = layout, seen = seen, character = character) } else if (is.character(x)) { subtrees <- ref_tree_chr(x, layout = layout, seen = seen) } From 3becc7406ccd7b2cc44887c1e6091160bacb3bfd Mon Sep 17 00:00:00 2001 From: Hadley Wickham Date: Fri, 17 Jun 2022 13:01:26 -0500 Subject: [PATCH 2/3] Add news bullet --- NEWS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS.md b/NEWS.md index 638640f..47590a3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,8 @@ # lobstr (development version) +* `ref()` lists all contents of environments even those with names beginning + with `.` (@krlmlr, #53). + * `obj_size()` and `sxp()` now support non-nil terminated pairlists. * `obj_sizes()` no longer returns NA for objects larger than 2^31 bytes (#45) From 6de3fb661ac9b0c0b84418e4b0999e5e2a6ea55c Mon Sep 17 00:00:00 2001 From: Hadley Wickham Date: Fri, 17 Jun 2022 13:01:31 -0500 Subject: [PATCH 3/3] Add test --- tests/testthat/_snaps/ref.md | 9 +++++++++ tests/testthat/test-ref.R | 11 +++++++++++ 2 files changed, 20 insertions(+) diff --git a/tests/testthat/_snaps/ref.md b/tests/testthat/_snaps/ref.md index 24d6dbd..ce1e7af 100644 --- a/tests/testthat/_snaps/ref.md +++ b/tests/testthat/_snaps/ref.md @@ -33,6 +33,15 @@ ├─b = [2:0x002] └─c = [1:0x001] +# environment shows objects beginning with . + + Code + e <- env(. = 1:10) + ref(e) + Output + █ [1:0x001] + └─. = [2:0x002] + # can display ref to global string pool on request Code diff --git a/tests/testthat/test-ref.R b/tests/testthat/test-ref.R index 878e7d9..4ac976c 100644 --- a/tests/testthat/test-ref.R +++ b/tests/testthat/test-ref.R @@ -28,6 +28,17 @@ test_that("basic environment display", { }) }) +test_that("environment shows objects beginning with .", { + skip_on_os("windows") + + test_addr_reset() + expect_snapshot({ + e <- env(. = 1:10) + ref(e) + }) +}) + + test_that("can display ref to global string pool on request", { skip_on_os("windows")