memoise now warns if the input function has already been memoised#4
Merged
jimhester merged 1 commit intor-lib:masterfrom Jan 25, 2016
Merged
memoise now warns if the input function has already been memoised#4jimhester merged 1 commit intor-lib:masterfrom
jimhester merged 1 commit intor-lib:masterfrom
Conversation
memoi[sz]e now warns if the input function has already been memoised.
jimhester
pushed a commit
that referenced
this pull request
Jan 19, 2016
is.memoised returns FALSE for non-functions
Member
|
I wonder if it would be best to just signal an error if the function is already memoised... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help documentation cautions about calling memoise on functions that have already been memoised, since it will reset the cache. It seems sensible to have a warning built-in to the function to notify the user when they are doing this.