Skip to content

Drop cache for particular arguments#78

Merged
jimhester merged 5 commits intor-lib:masterfrom
richardkunze:drop_cache
Oct 25, 2018
Merged

Drop cache for particular arguments#78
jimhester merged 5 commits intor-lib:masterfrom
richardkunze:drop_cache

Conversation

@richardkunze
Copy link
Contributor

This PR addresses #66.

I added a function drop_cache working exactly like has_cache but removing the cache for the given arguments. It should support all possible caching functions but I only tested memory and filesystem due to missing S3/GCS credentials.

@codecov-io
Copy link

codecov-io commented Oct 24, 2018

Codecov Report

Merging #78 into master will decrease coverage by 16.68%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #78       +/-   ##
===========================================
- Coverage   76.41%   59.72%   -16.69%     
===========================================
  Files           5        5               
  Lines         195      221       +26     
===========================================
- Hits          149      132       -17     
- Misses         46       89       +43
Impacted Files Coverage Δ
R/cache_gcs.R 0% <0%> (ø) ⬆️
R/cache_s3.R 0% <0%> (-100%) ⬇️
R/cache_filesystem.R 100% <100%> (ø) ⬆️
R/memoise.R 100% <100%> (ø) ⬆️
R/cache_memory.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a06c2c...ca62c02. Read the comment docs.

@jimhester
Copy link
Member

This looks good, thanks! I think all that is missing is adding a note to NEWS.md detailing the change, with this PR number and your GitHub username.

@jimhester
Copy link
Member

Thanks!

@jimhester jimhester merged commit 99db7eb into r-lib:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants