Drop cache for particular arguments#78
Merged
jimhester merged 5 commits intor-lib:masterfrom Oct 25, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
===========================================
- Coverage 76.41% 59.72% -16.69%
===========================================
Files 5 5
Lines 195 221 +26
===========================================
- Hits 149 132 -17
- Misses 46 89 +43
Continue to review full report at Codecov.
|
Member
|
This looks good, thanks! I think all that is missing is adding a note to NEWS.md detailing the change, with this PR number and your GitHub username. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #66.
I added a function drop_cache working exactly like has_cache but removing the cache for the given arguments. It should support all possible caching functions but I only tested memory and filesystem due to missing S3/GCS credentials.