Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Control significant figures with an option #72
For instance, I see that
But you'll have to explain to me how the digits
The underlying problem here is #57 - I think if we fix that an option will not be necessary.
I'd prefer to push as far as we can before introducing more options, since options substantially increase the testing complexity, and make the package behave differently for different people. If this new behaviour is too annoying, we can definitely consider options, but I'd like to give it more time (i.e. open again in 6 months time if it's still a problem and I'll be more amenable)
changed the title from
Consider use of `options` or similar to control styling behavior?
Control significant figures with an option
Jan 8, 2018
referenced this issue
Jan 9, 2018
Unaware of this issue, I was actually already in the middle of implementing this kind of option for my own use. But then I came here to check if there was any discussion in more general terms about the question of left-hand-sides of numbers and significant digits vs. thousands separators.
As a little background, I was surprised at first when I saw that in e.g.
Since I didn't want to use it that way, I started to implement an option so I could use
But then I got to thinking that would the thousands separator idea actually be a more useful use case for the colors than significant digits? Consistency is important, but since
I definitely haven't looked into this very deeply, so there might be fairly obvious factors at play that make my suggestion ridiculous. Or maybe it's just plain stupid. But since I have spent a fair amount of time staring at integers on the scale of millions (base pair numbers in the human genome), I for one see a lot of potential in this kind of representation (color formatting) of thousands separators. Use of commas, or extra characters in general, is problematic for copy&paste.
Or maybe keep significant digits behaving as it is, but include a new option for the thousands separator. That one could default to not be shown, but when set, it would override the significant digits on the lhs.
I'm happy to work on this and make a PR if it's deemed useful.
I agree that this has to change. The current implementation makes inspecting tibbles almost impossible for me. I LOVE the alignment along decimal points, but the forced highlight of only three digits is confusing at best. Not only is this unintuitive (as cboettig indicates), it is visually distracting
added a commit
Jan 11, 2018
added a commit
Jan 11, 2018
Thank you for the new options in #79!
However, I still think there should either be
I really like having