New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column width truncation is too aggressive #75

Closed
hadley opened this Issue Jan 8, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@hadley
Member

hadley commented Jan 8, 2018

Especially given that there's no display of the full names.

@hadley

This comment has been minimized.

Member

hadley commented Jan 8, 2018

I'd suggest at least 10 characters, maybe 15.

In a future release we should provide footnotes (or similar) so you can look up the full name

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 9, 2018

We could just use base::abbreviate() to keep the column names unique. For now I'll implement an option that turns off abbreviation for column names (option(pillar.colnames = "full") vs. option(pillar.colnames = "trunc")), we'll add further values later.

@hadley

This comment has been minimized.

Member

hadley commented Jan 9, 2018

I don't think abbreviate is a good solution because you'll still need someway to map what you see back to $ etc. I think we just need to be much less aggressive here. Increasing the minimum width constant is an easy way to fix this problem, and we can come back to better solutions in the future

@krlmlr krlmlr closed this in #79 Jan 11, 2018

krlmlr added a commit that referenced this issue Jan 11, 2018

Add options to control behavior (#79)
- New options to control the output, with defaults that match the current behavior unless stated otherwise:

    - `pillar.sigfig` to control the number of significant digits, for highlighting and truncation (#72),
    - `pillar.subtle` to specify if insignificant digits should be printed in gray (#72),
    - `pillar.neg` to specify if negative digits should be printed in red,
    - `pillar.bold` to specify if column headers should be printed in bold (default: `FALSE`, #76),
    - `pillar.min_title_chars` to specify the minimum number of characters to display for each column name (default: 15 characters, #75).

krlmlr added a commit that referenced this issue Jan 11, 2018

Merge tag 'v1.0.99.9000'
- `NA` values are now shown in plain red, without changing the background color (#70).
- New options to control the output, with defaults that match the current behavior unless stated otherwise:
    - `pillar.sigfig` to control the number of significant digits, for highlighting and truncation (#72),
    - `pillar.subtle` to specify if insignificant digits should be printed in gray (#72),
    - `pillar.neg` to specify if negative digits should be printed in red,
    - `pillar.bold` to specify if column headers should be printed in bold (default: `FALSE`, #76),
    - `pillar.min_title_chars` to specify the minimum number of characters to display for each column name (default: 15 characters, #75).
- Shortened abbreviations for types: complex: cplx -> cpl, function: fun -> fn, factor: fctr -> fct (#71).
- Date columns now show sub-seconds if the `digits.secs` option is set (#74).
- Work around failing CRAN tests on Windows.

krlmlr added a commit that referenced this issue Jan 19, 2018

Merge tag 'v1.1.0'
- `NA` values are now shown in plain red, without changing the background color (#70).
- New options to control the output, with defaults that match the current behavior unless stated otherwise:
    - `pillar.sigfig` to control the number of significant digits, for highlighting and truncation (#72),
    - `pillar.subtle` to specify if insignificant digits should be printed in gray (#72),
    - `pillar.neg` to specify if negative digits should be printed in red,
    - `pillar.bold` to specify if column headers should be printed in bold (default: `FALSE`, #76),
    - `pillar.min_title_chars` to specify the minimum number of characters to display for each column name (default: 15 characters, #75).
- Shortened abbreviations for types: complex: cplx -> cpl, function: fun -> fn, factor: fctr -> fct (#71).
- Date columns now show sub-seconds if the `digits.secs` option is set (#74).
- Very wide tibbles now print faster (#85).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment