New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance problems #85

Closed
krlmlr opened this Issue Jan 14, 2018 · 0 comments

Comments

Projects
1 participant
@krlmlr
Member

krlmlr commented Jan 14, 2018

  • Slow printing of wide tibbles, tidyverse/tibble#360
  • Sometimes results in a delay between printing the body and the footer

Reasons:

  • unnecessary calls to pillar() for columns that are never shown
  • slow getOption() with default argument set
    • It is slow, but not *that" slow
  • unnecessary calls to crayon::make_style()

@krlmlr krlmlr closed this in #87 Jan 14, 2018

@krlmlr krlmlr added this to Done in krlmlr Jan 14, 2018

krlmlr added a commit that referenced this issue Jan 14, 2018

Merge tag 'v1.0.99.9001'
- Very wide tibbles now print faster (#85).

krlmlr added a commit that referenced this issue Jan 19, 2018

Merge tag 'v1.1.0'
- `NA` values are now shown in plain red, without changing the background color (#70).
- New options to control the output, with defaults that match the current behavior unless stated otherwise:
    - `pillar.sigfig` to control the number of significant digits, for highlighting and truncation (#72),
    - `pillar.subtle` to specify if insignificant digits should be printed in gray (#72),
    - `pillar.neg` to specify if negative digits should be printed in red,
    - `pillar.bold` to specify if column headers should be printed in bold (default: `FALSE`, #76),
    - `pillar.min_title_chars` to specify the minimum number of characters to display for each column name (default: 15 characters, #75).
- Shortened abbreviations for types: complex: cplx -> cpl, function: fun -> fn, factor: fctr -> fct (#71).
- Date columns now show sub-seconds if the `digits.secs` option is set (#74).
- Very wide tibbles now print faster (#85).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment