Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to control behavior #79

Merged
merged 15 commits into from Jan 11, 2018
Merged

Add options to control behavior #79

merged 15 commits into from Jan 11, 2018

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 10, 2018 •
edited

Default to current implementation, unless stated otherwise.

@krlmlr krlmlr requested a review from hadley January 10, 2018 20:32
hadley
hadley approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only question I have is if 10 is enough. Maybe err on the side of caution and use 15?

@krlmlr krlmlr merged commit 614bb49 into r-lib:master Jan 11, 2018
@krlmlr krlmlr deleted the f-options branch January 11, 2018 08:17
@ilarischeinin ilarischeinin mentioned this pull request Jan 11, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@krlmlr @hadley