Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contributing guide and code of conduct more prominent when available? #1044

Closed
maelle opened this issue May 27, 2019 · 5 comments · Fixed by #1055
Closed

Make contributing guide and code of conduct more prominent when available? #1044

maelle opened this issue May 27, 2019 · 5 comments · Fixed by #1055

Comments

@maelle
Copy link
Collaborator

@maelle maelle commented May 27, 2019

When available, could/should the pages "CONTRIBUTING" and "CODE_OF_CONDUCT" be highlighted from the sidebar/navbar by default? Maybe as a "community" section to use GitHub's words?

E.g. at the moment https://pkgdown.r-lib.org/CODE_OF_CONDUCT seems to be linked from the bottom of the README only and I'm not sure where https://pkgdown.r-lib.org/CONTRIBUTING is linked from.

@jayhesselberth
Copy link
Collaborator

@jayhesselberth jayhesselberth commented May 27, 2019

Yeah these could be surfaced more deliberately. Putting them is a dedicated "community" sidebar section seems reasonable to me.

@maelle
Copy link
Collaborator Author

@maelle maelle commented May 27, 2019

Ping me if a PR is welcome. :-)

@maelle
Copy link
Collaborator Author

@maelle maelle commented Jun 5, 2019

Happy to make a PR if the feature is welcome (I'd be an user 😸 ).

@jayhesselberth
Copy link
Collaborator

@jayhesselberth jayhesselberth commented Jun 5, 2019

Go ahead with a PR. I think I'd put the section between "Links" and "License". We might have to slightly reduce the side of the sidebar headers to make it all fit.

@maelle
Copy link
Collaborator Author

@maelle maelle commented Jun 5, 2019

We might have to slightly reduce the side of the sidebar headers to make it all fit.

Why? It seems to fit right now in my PR but I might be missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants