add external link icon by default for external links in the navbar?

[maelle]

both nav items and the dropdown.

[maelle]

example where I'd have expected it, somehow: http://openintrostat.github.io/openintro/index.html

[hadley]

Couldn't the user be responsible for that? (Do we have an easy way to have icon + text?)

[mine-cetinkaya-rundel]

I agree that it would be useful to indicate you're being sent elsewhere, and ideally, there would be a way to indicate "open in new tab" (or is there already?)

[maelle]

Couldn't the user be responsible for that?

I liked the idea of having it by default.

(Do we have an easy way to have icon + text?)

It doesn't seem so, I'll check soon-ish.

I agree that it would be useful to indicate you're being sent elsewhere, and ideally, there would be a way to indicate "open in new tab" (or is there already?)

I think I remember it's viewed as bad practice. 🤔

[hadley]

Yeah, I expect that users know how to use the appropriate browser invocation to open in a different tab if they want that.

[maelle]

One can specify both text and icon, but in that case, the icon comes before the text which sounds logical when it's not an external link icon.

pkgdown/R/navbar.R

Line 265 in 46764c0

htmltools::tagList(htmltools::tags$span(class = paste(iconset, x$icon)), " ", x$text, ...)

[hadley]

I'm not sure this is worth it, given all the other work that we have to do.