Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks to default pkgdown site layout? #1989

Closed
kevinushey opened this issue Jan 5, 2022 · 2 comments
Closed

tweaks to default pkgdown site layout? #1989

kevinushey opened this issue Jan 5, 2022 · 2 comments
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues
Milestone

Comments

@kevinushey
Copy link
Contributor

These are obviously subjective, so please feel free to discard these if you think they're not really an improvement or not worth doing.

Using pkgdown's own page as an example...

Screen Shot 2022-01-04 at 4 11 14 PM

  • The alignment of the package name + package version could be improved. (I would prefer to see the package name + version vertically aligned.)
  • The navbar list items could use some extra padding, and spacing away from the package name + version.
  • The vignette text could be separated a little bit more from the vignette title header.

For example:

Screen Shot 2022-01-04 at 4 16 58 PM

Obviously users could make these changes themselves, but IMHO these changes might be worth considering for the default layout.

@hadley hadley added feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues labels Jan 6, 2022
@hadley hadley added this to the v2.0.2 milestone Jan 6, 2022
@hadley
Copy link
Member

hadley commented Jan 6, 2022

I'll take a look — the main challenges are making the default appearance look better without harming the ability to customise as needed and my css skills.

@hadley
Copy link
Member

hadley commented Jan 7, 2022

  1. Looks like align-items: baseline; will do it
  2. Change ms-2 to ms-3 to increase the gap between version and section titles. Could add class="me-1" to each li.list-item in HTML or gap: 0.25rem to .navbar-nav in CSS, but it doesn't feel that cramped to me and horizontal space is at a premium in the navbar (especially when folks at extra items), so unless you feel strongly, I'd prefer to leave as is. (You can pretty easily customise for your own site with pkgdown/extra.scss if needed).
  3. I don't find this too offensive currently — I don't really like how bootstrap does margins for headings, but it's hard to pull on one thread without having to tweak everything, which then makes it harder to customise. You might prefer the styling of https://tidytemplate.tidyverse.org/articles/headings.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues
Projects
None yet
Development

No branches or pull requests

2 participants