New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar highlighting is seemingly random in individual reference pages #777

Open
ArtemSokolov opened this Issue Aug 1, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@ArtemSokolov

ArtemSokolov commented Aug 1, 2018

Dear developers,

What controls which element is highlighted in the navbar when a user navigates individual Reference pages? Taking a look at pkgdown itself, the Reference index correctly highlights "Reference" in the navbar. However, individual reference pages highlight the home button.

Looking at other packages, we find that reference pages in qqplotr highlight "Articles". Reference pages in my own package that I'm currently putting together seem to highlight yet another (custom) element called "Data".

This behavior appears somewhat arbitrary. Am I just missing an option somewhere? If not, I think the logical default behavior is to have individual reference pages continue highlighting "Reference" in the navbar.

Best,
-Artem

@hrecht

This comment has been minimized.

Show comment
Hide comment
@hrecht

hrecht Aug 24, 2018

Hi pkgdown team, I have noticed this same issue as well - individual function reference pages highlight the next tab over in the navbar, not the Reference tab. An example from my package: on each function reference page, the first vignette tab is highlighted.

screen shot 2018-08-23 at 8 29 55 pm

source: https://hrecht.github.io/censusapi/reference/getCensus.html

Is there a yaml option or something we could use that would solve this?

hrecht commented Aug 24, 2018

Hi pkgdown team, I have noticed this same issue as well - individual function reference pages highlight the next tab over in the navbar, not the Reference tab. An example from my package: on each function reference page, the first vignette tab is highlighted.

screen shot 2018-08-23 at 8 29 55 pm

source: https://hrecht.github.io/censusapi/reference/getCensus.html

Is there a yaml option or something we could use that would solve this?

@hadley

This comment has been minimized.

Show comment
Hide comment
@hadley

hadley Sep 13, 2018

Member

This is a bug; I don't think it would make sense to have an option that randomly highlights the incorrect navbar item.

Member

hadley commented Sep 13, 2018

This is a bug; I don't think it would make sense to have an option that randomly highlights the incorrect navbar item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment