New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using a custom navbar, the home page button is lost #911

Closed
DavisVaughan opened this Issue Nov 21, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@DavisVaughan
Copy link
Contributor

DavisVaughan commented Nov 21, 2018

One of two things is supposed to happen when you use a custom navbar, as ggplot2 does:

image

  1. The home button (the little house) is lost, but Reference should not be highlighted as it is when you go to the home page. If the loss of the home button is the correct behavior, I guess there should be an easy way to get that home button back when you use a custom navbar, and make sure it highlights appropriately when you do go to the home page?

  2. The home button should never have been lost in the first place, even with a custom navbar. Then the highlight behavior should be correct because it will highlight the home button since it will be the first element in the navbar

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Nov 22, 2018

This bug was probably introduced when fixing #777

@hadley hadley added this to the pkgdown 1.2.1 milestone Dec 3, 2018

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Dec 3, 2018

I think this might be an off-by-one error. 😱

@hadley hadley closed this in e802bbb Dec 5, 2018

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Dec 5, 2018

It worked locally, but the published version of the ggplot2 site now doesn't highlight any navbar: http://ggplot2.tidyverse.org/

@hadley hadley reopened this Dec 5, 2018

@hadley hadley closed this in d84175f Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment