Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sidebar on mobile homepage #913

Closed
jayhesselberth opened this issue Nov 21, 2018 · 2 comments
Closed

Hide sidebar on mobile homepage #913

jayhesselberth opened this issue Nov 21, 2018 · 2 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@jayhesselberth
Copy link
Collaborator

/* hide sidebar on mobile devices */
@media (max-width: 767px) {
  #sidebar {
    display: none;
  }
}
@hadley
Copy link
Member

hadley commented Nov 22, 2018

Aren't we already doing that?

@jayhesselberth
Copy link
Collaborator Author

This bug was introduced in #834.

The div in content-home.html is missing the hidden classes:

<div class="col-md-3" id="sidebar">

It should be:

<div class="col-md-3 hidden-xs hidden-sm" id="sidebar">

@jayhesselberth jayhesselberth changed the title Hide sidebar on mobile Hide sidebar on mobile homepage Nov 22, 2018
@jayhesselberth jayhesselberth added the bug an unexpected problem or unintended behavior label Nov 22, 2018
jayhesselberth added a commit that referenced this issue Nov 22, 2018
jayhesselberth added a commit that referenced this issue Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants